Skip to content

update default models#180

Merged
p- merged 6 commits intomainfrom
p--update-default-models
Apr 2, 2026
Merged

update default models#180
p- merged 6 commits intomainfrom
p--update-default-models

Conversation

@p-
Copy link
Copy Markdown
Contributor

@p- p- commented Apr 2, 2026

update + tested default models

Copilot AI review requested due to automatic review settings April 2, 2026 07:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the agent’s provider-specific default model IDs used when no COPILOT_DEFAULT_MODEL override is set, aligning defaults with newer GPT model naming across supported endpoints.

Changes:

  • Switch default model for api.githubcopilot.com from gpt-4o to gpt-4.1.
  • Switch default model for models.github.ai from openai/gpt-4o to openai/gpt-4.1.
  • Switch default model for api.openai.com from gpt-4o to gpt-4.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 2, 2026 09:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 41 to +48
api_endpoint = get_AI_endpoint()
match urlparse(api_endpoint).netloc:
case AI_API_ENDPOINT_ENUM.AI_API_GITHUBCOPILOT:
default_model = "gpt-4o"
default_model = "gpt-4.1"
case AI_API_ENDPOINT_ENUM.AI_API_MODELS_GITHUB:
default_model = "openai/gpt-4o"
default_model = "openai/gpt-4.1"
case AI_API_ENDPOINT_ENUM.AI_API_OPENAI:
default_model = "gpt-4o"
default_model = "gpt-4.1"
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the runtime default model from gpt-4o to gpt-4.1 makes existing documentation inaccurate (e.g., doc/GRAMMAR.md explicitly states the default is gpt-4o). Please update the docs (and any other user-facing references) to reflect the new default so users aren’t misled when they omit model: in task definitions.

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings April 2, 2026 09:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonnet_latest: claude-sonnet-4.5
gpt_default: gpt-4.1
gpt_latest: gpt-5

Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpt_latest (and the previously defined Claude aliases) are removed from the example model_config, but other repository examples and docs still reference gpt_latest (e.g., README “Model configs” section, doc/GRAMMAR.md model_config example, and examples/taskflows/CVE-2023-2283.yaml uses model: gpt_latest with this config). With this change, those taskflows will pass gpt_latest through as the provider model ID and likely fail at runtime. Consider either reintroducing gpt_latest (mapping to the desired provider model) or updating the referenced docs/taskflows to use gpt_default (or another existing key).

Suggested change
gpt_latest: gpt-4.1

Copilot uses AI. Check for mistakes.
Comment thread doc/GRAMMAR.md
```

Note that model identifiers may differ between OpenAI compatible endpoint providers, make sure you change your model identifier accordingly when switching providers. If not specified, a default LLM model (`gpt-4o`) is used.
Note that model identifiers may differ between OpenAI compatible endpoint providers, make sure you change your model identifier accordingly when switching providers. If not specified, a default LLM model (such as `gpt-4.1`) is used.
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note now suggests a default model like gpt-4.1, but the actual default model identifier is endpoint-specific (e.g., models.github.ai defaults to a namespaced ID like openai/gpt-4.1 in src/seclab_taskflow_agent/agent.py). To avoid confusion for users switching endpoints, consider explicitly stating that the default model string depends on AI_API_ENDPOINT and may be namespaced, rather than implying a single identifier.

Suggested change
Note that model identifiers may differ between OpenAI compatible endpoint providers, make sure you change your model identifier accordingly when switching providers. If not specified, a default LLM model (such as `gpt-4.1`) is used.
Note that model identifiers, including the default model string, depend on the configured `AI_API_ENDPOINT` and may be namespaced (for example, `openai/gpt-4.1` on some endpoints). When switching providers, make sure you update your model identifier accordingly. If `model` is not specified in a task, the endpoint's own default LLM model will be used (which may be `gpt-4.1` or another provider-specific default).

Copilot uses AI. Check for mistakes.
@p- p- merged commit d9d8e6c into main Apr 2, 2026
13 checks passed
@p- p- deleted the p--update-default-models branch April 2, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants